Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HTML pages for OIDC resources under /profile/ #4136

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Add HTML pages for OIDC resources under /profile/ #4136

merged 1 commit into from
Oct 22, 2023

Conversation

segiddins
Copy link
Member

@segiddins segiddins commented Oct 17, 2023 •
edited
Loading

@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

Merging #4136 (a2200a5) into master (885f10e) will increase coverage by 0.00%.
The diff coverage is 98.92%.

@@           Coverage Diff            @@
##           master    #4136    +/-   ##
========================================
  Coverage   98.89%   98.89%            
========================================
  Files         279      295    +16     
  Lines        6317     6687   +370     
========================================
+ Hits         6247     6613   +366     
- Misses         70       74     +4
Files Coverage Δ
...ontrollers/api/v1/oidc/api_key_roles_controller.rb 97.22% <100.00%> (ø)
app/controllers/api_keys_controller.rb 98.27% <100.00%> (ø)
app/controllers/oidc/id_tokens_controller.rb 100.00% <100.00%> (ø)
app/controllers/oidc/providers_controller.rb 100.00% <100.00%> (ø)
app/helpers/duration_helper.rb 100.00% <100.00%> (ø)
app/helpers/oidc/api_key_roles_helper.rb 100.00% <100.00%> (ø)
app/helpers/oidc/providers_helper.rb 100.00% <100.00%> (ø)
app/helpers/rubygems_helper.rb 100.00% <100.00%> (ø)
app/models/oidc/access_policy.rb 100.00% <100.00%> (ø)
app/models/oidc/api_key_permissions.rb 100.00% <100.00%> (ø)
... and 13 more

@segiddins segiddins mentioned this pull request Oct 17, 2023
Open
3 tasks
@segiddins segiddins force-pushed the oidc-api-tokens branch 2 times, most recently from c5fa374 to d835e77 Compare October 18, 2023 01:11
@rubygems-org-shipit rubygems-org-shipit bot temporarily deployed to oidc-api-token October 18, 2023 04:53 Inactive
@segiddins
Copy link
Member Author

segiddins commented Oct 18, 2023 •
edited
Loading

From review w/ @indirect:

  • soft delete for API key roles
  • if generating name for form, generate unique name
  • change yaml name to push_gem.yml
  • add name to generated yaml
  • on gh workflow page, add instructions: "bump version, push tag" -- link to bundler guide for "creating gem > releasing the gem" for gem bump info, then rake release:source_control_push
  • change on push to '[v*]`
  • in generated YAML, put server if not https://rubygem.org
  • gem await use --source if not default
  • link_to_unless_current on table partials

@segiddins segiddins force-pushed the oidc-api-tokens branch 2 times, most recently from 193a9e0 to 73bc335 Compare October 19, 2023 02:20
@rubygems-org-shipit rubygems-org-shipit bot temporarily deployed to oidc-api-token October 19, 2023 02:31 Inactive
@segiddins segiddins changed the title [WIP] Add HTML pages for OIDC resources under /profile/ Add HTML pages for OIDC resources under /profile/ Oct 19, 2023
@segiddins segiddins marked this pull request as ready for review October 19, 2023 02:42
indirect
indirect approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@indirect indirect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! I spotted a couple of bits I don't think you meant to include, but I think this is good to go.

app/assets/javascripts/oidc_api_key_role_form.js Outdated Show resolved Hide resolved
db/schema.rb Outdated Show resolved Hide resolved
@segiddins segiddins merged commit 8907e31 into master Oct 22, 2023
17 checks passed
@segiddins segiddins deleted the oidc-api-tokens branch October 22, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@indirect indirect indirect approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@segiddins @indirect